From a423c38e42c171806e5e94fbb9487ed4cd19af4c Mon Sep 17 00:00:00 2001
From: Stian Thorgersen <stianst@gmail.com>
Date: Fri, 6 Dec 2013 19:08:50 +0000
Subject: [PATCH 1/3] KEYCLOAK-214 view all users in a realm through admin
 console

---
 .../resources/admin/js/controllers/users.js   | 15 ++++++++-------
 .../resources/admin/partials/user-list.html   |  4 ++--
 .../java/org/keycloak/models/RealmModel.java  |  2 ++
 .../org/keycloak/models/jpa/RealmAdapter.java |  9 +++++++++
 .../models/picketlink/RealmAdapter.java       | 19 ++++++++++++-------
 .../resources/admin/UsersResource.java        | 19 +++++++++++--------
 6 files changed, 44 insertions(+), 24 deletions(-)

diff --git a/admin-ui/src/main/resources/META-INF/resources/admin/js/controllers/users.js b/admin-ui/src/main/resources/META-INF/resources/admin/js/controllers/users.js
index de73f6333a7..f2c6b7c1fc4 100755
--- a/admin-ui/src/main/resources/META-INF/resources/admin/js/controllers/users.js
+++ b/admin-ui/src/main/resources/META-INF/resources/admin/js/controllers/users.js
@@ -120,15 +120,16 @@ module.controller('UserListCtrl', function($scope, realm, User) {
     $scope.realm = realm;
     $scope.searchQuery = function() {
         $scope.searchLoaded = false;
+        $scope.currentSearch = $scope.search;
+
+        var params = { realm: realm.id };
         if ($scope.search) {
-            $scope.currentSearch = $scope.search;
-            $scope.users = User.query({ realm: realm.id, search : $scope.search }, function() {
-                $scope.searchLoaded = true;
-            });
-        } else {
-            $scope.currentSearch = null;
-            $scope.users = null;
+            params.search = $scope.search;
         }
+
+        $scope.users = User.query(params, function() {
+            $scope.searchLoaded = true;
+        });
     };
 });
 
diff --git a/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html b/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
index c79b243125e..b29f3ebcc3a 100755
--- a/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
+++ b/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
@@ -14,7 +14,7 @@
                 </ol>
                 <h2><span>{{realm.realm}}</span> Users</h2>
                 <table>
-                    <caption data-ng-show="users && search" class="hidden">Table of realm users</caption>
+                    <caption data-ng-show="users" class="hidden">Table of realm users</caption>
                     <thead>
                         <tr>
                             <th class="rcue-table-actions" colspan="4">
@@ -66,7 +66,7 @@
                 <div class="feedback warning inline" data-ng-show="searchLoaded && users.length == 0">
                     <p><strong>Your search returned no results.</strong><br>Try modifying the query and try again.</p>
                 </div>
-                <div class="feedback info inline" data-ng-show="!currentSearch">
+                <div class="feedback info inline" data-ng-show="!users">
                     <br/>
                     <p><strong>Search for users.</strong><br>Please enter a search to display users.</p>
                 </div>
diff --git a/model/api/src/main/java/org/keycloak/models/RealmModel.java b/model/api/src/main/java/org/keycloak/models/RealmModel.java
index a4527ae1aad..ce76dcb45a9 100755
--- a/model/api/src/main/java/org/keycloak/models/RealmModel.java
+++ b/model/api/src/main/java/org/keycloak/models/RealmModel.java
@@ -137,6 +137,8 @@ public interface RealmModel extends RoleContainerModel, RoleMapperModel, ScopeMa
 
     public void setAutomaticRegistrationAfterSocialLogin(boolean automaticRegistrationAfterSocialLogin);
 
+    List<UserModel> getUsers();
+
     List<UserModel> searchForUser(String search);
 
     List<UserModel> searchForUserByAttributes(Map<String, String> attributes);
diff --git a/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java b/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
index 6e6c8f11869..0e8f8797393 100755
--- a/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
+++ b/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
@@ -670,6 +670,15 @@ public class RealmAdapter implements RealmModel {
         em.flush();
     }
 
+    @Override
+    public List<UserModel> getUsers() {
+        TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u", UserEntity.class);
+        List<UserEntity> results = query.getResultList();
+        List<UserModel> users = new ArrayList<UserModel>();
+        for (UserEntity entity : results) users.add(new UserAdapter(entity));
+        return users;
+    }
+
     @Override
     public List<UserModel> searchForUser(String search) {
         TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u where u.realm = :realm and lower(u.loginName) like :search or lower(concat(u.firstName, ' ', u.lastName)) like :search or u.email like :search", UserEntity.class);
diff --git a/model/picketlink/src/main/java/org/keycloak/models/picketlink/RealmAdapter.java b/model/picketlink/src/main/java/org/keycloak/models/picketlink/RealmAdapter.java
index 798643e8158..fb2dca68f11 100755
--- a/model/picketlink/src/main/java/org/keycloak/models/picketlink/RealmAdapter.java
+++ b/model/picketlink/src/main/java/org/keycloak/models/picketlink/RealmAdapter.java
@@ -914,23 +914,28 @@ public class RealmAdapter implements RealmModel {
         getRelationshipManager().remove(relationship);
     }
 
+    @Override
+    public List<UserModel> getUsers() {
+        List<UserModel> userModels = new ArrayList<UserModel>();
+        IdentityQuery<User> query = getIdm().createIdentityQuery(User.class);
+        for (User u : query.getResultList()) {
+            userModels.add(new UserAdapter(u, idm));
+        }
+        return userModels;
+    }
+
     @Override
     public List<UserModel> searchForUser(String search) {
         QueryParameter[] params = new QueryParameter[] { User.LOGIN_NAME, User.FIRST_NAME, User.LAST_NAME, User.EMAIL };
 
-        Map<String, User> users = new HashMap<String, User>();
+        List<UserModel> userModels = new ArrayList<UserModel>();
         for (QueryParameter p : params) {
             IdentityQuery<User> query = getIdm().createIdentityQuery(User.class);
             query.setParameter(p, search.toLowerCase());
             for (User u : query.getResultList()) {
-                users.put(u.getLoginName(), u);
+                userModels.add(new UserAdapter(u, idm));
             }
         }
-
-        List<UserModel> userModels = new ArrayList<UserModel>();
-        for (User user : users.values()) {
-            userModels.add(new UserAdapter(user, idm));
-        }
         return userModels;
     }
 
diff --git a/services/src/main/java/org/keycloak/services/resources/admin/UsersResource.java b/services/src/main/java/org/keycloak/services/resources/admin/UsersResource.java
index 61e70bf6826..e8e34c76e1b 100755
--- a/services/src/main/java/org/keycloak/services/resources/admin/UsersResource.java
+++ b/services/src/main/java/org/keycloak/services/resources/admin/UsersResource.java
@@ -135,14 +135,10 @@ public class UsersResource {
                                              @QueryParam("username") String username) {
         RealmManager manager = new RealmManager(session);
         List<UserRepresentation> results = new ArrayList<UserRepresentation>();
+        List<UserModel> userModels;
         if (search != null) {
-            List<UserModel> userModels = manager.searchUsers(search, realm);
-            for (UserModel user : userModels) {
-                if (isUser(user)) {
-                    results.add(manager.toRepresentation(user));
-                }
-            }
-        } else {
+            userModels = manager.searchUsers(search, realm);
+        } else if (last != null || first != null || email != null || username != null) {
             Map<String, String> attributes = new HashMap<String, String>();
             if (last != null) {
                 attributes.put(UserModel.LAST_NAME, last);
@@ -156,11 +152,18 @@ public class UsersResource {
             if (username != null) {
                 attributes.put(UserModel.LOGIN_NAME, username);
             }
-            List<UserModel> userModels = realm.searchForUserByAttributes(attributes);
+            userModels = realm.searchForUserByAttributes(attributes);
             for (UserModel user : userModels) {
                 results.add(manager.toRepresentation(user));
             }
+        } else {
+            userModels = realm.getUsers();
+        }
 
+        for (UserModel user : userModels) {
+            if (isUser(user)) {
+                results.add(manager.toRepresentation(user));
+            }
         }
         return results;
     }

From c514e6c15220b362a94a7ec80159ea71d9db1bc3 Mon Sep 17 00:00:00 2001
From: Stian Thorgersen <stianst@gmail.com>
Date: Fri, 6 Dec 2013 19:22:55 +0000
Subject: [PATCH 2/3] KEYCLOAK-197 Fix search for users returns users for all
 realms

---
 .../META-INF/resources/admin/partials/user-list.html        | 1 +
 .../src/main/java/org/keycloak/models/jpa/RealmAdapter.java | 5 +++--
 services/src/test/java/org/keycloak/test/AdapterTest.java   | 6 ++++--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html b/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
index b29f3ebcc3a..96cee2177c6 100755
--- a/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
+++ b/admin-ui/src/main/resources/META-INF/resources/admin/partials/user-list.html
@@ -28,6 +28,7 @@
                                     </button>
                                 </div>
                                 <div class="actions">
+                                    <button ng-click="search = null; searchQuery()">View all</button>
                                     <a class="button" href="#/create/user/{{realm.id}}">Add User</a>
                                 </div>
                             </th>
diff --git a/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java b/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
index 0e8f8797393..201f286dcaa 100755
--- a/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
+++ b/model/jpa/src/main/java/org/keycloak/models/jpa/RealmAdapter.java
@@ -672,7 +672,8 @@ public class RealmAdapter implements RealmModel {
 
     @Override
     public List<UserModel> getUsers() {
-        TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u", UserEntity.class);
+        TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u where u.realm = :realm", UserEntity.class);
+        query.setParameter("realm", realm);
         List<UserEntity> results = query.getResultList();
         List<UserModel> users = new ArrayList<UserModel>();
         for (UserEntity entity : results) users.add(new UserAdapter(entity));
@@ -681,7 +682,7 @@ public class RealmAdapter implements RealmModel {
 
     @Override
     public List<UserModel> searchForUser(String search) {
-        TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u where u.realm = :realm and lower(u.loginName) like :search or lower(concat(u.firstName, ' ', u.lastName)) like :search or u.email like :search", UserEntity.class);
+        TypedQuery<UserEntity> query = em.createQuery("select u from UserEntity u where u.realm = :realm and ( lower(u.loginName) like :search or lower(concat(u.firstName, ' ', u.lastName)) like :search or u.email like :search )", UserEntity.class);
         query.setParameter("realm", realm);
         query.setParameter("search", "%" + search.toLowerCase() + "%");
         List<UserEntity> results = query.getResultList();
diff --git a/services/src/test/java/org/keycloak/test/AdapterTest.java b/services/src/test/java/org/keycloak/test/AdapterTest.java
index a600f6f67e2..0bcfbc5bdb3 100755
--- a/services/src/test/java/org/keycloak/test/AdapterTest.java
+++ b/services/src/test/java/org/keycloak/test/AdapterTest.java
@@ -303,7 +303,6 @@ public class AdapterTest extends AbstractKeycloakTest {
         }
 
         RealmManager adapter = getRealmManager();
-        adapter.createRealm("other").addUser("bburke");
 
         {
             List<UserModel> userModels = adapter.searchUsers("total junk query", realmModel);
@@ -438,8 +437,11 @@ public class AdapterTest extends AbstractKeycloakTest {
             }
         }
 
+        RealmModel otherRealm = adapter.createRealm("other");
+        otherRealm.addUser("bburke");
 
-
+        Assert.assertEquals(1, otherRealm.getUsers().size());
+        Assert.assertEquals(1, otherRealm.searchForUser("u").size());
     }
 
 

From 805863dde691471b5a11bc34b8c741180971e6ec Mon Sep 17 00:00:00 2001
From: Stian Thorgersen <stianst@gmail.com>
Date: Fri, 6 Dec 2013 19:33:28 +0000
Subject: [PATCH 3/3] KEYCLOAK-198 Search or apps

---
 .../META-INF/resources/admin/partials/application-list.html   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/admin-ui/src/main/resources/META-INF/resources/admin/partials/application-list.html b/admin-ui/src/main/resources/META-INF/resources/admin/partials/application-list.html
index 16a16972e10..a3b193671ad 100755
--- a/admin-ui/src/main/resources/META-INF/resources/admin/partials/application-list.html
+++ b/admin-ui/src/main/resources/META-INF/resources/admin/partials/application-list.html
@@ -21,7 +21,7 @@
                     <tr>
                         <th class="rcue-table-actions" colspan="3">
                             <div class="search-comp clearfix">
-                                <input type="text" placeholder="Search..." class="search"
+                                <input type="text" placeholder="Search..." class="search" data-ng-model="search.name"
                                        onkeyup="if(event.keyCode == 13){$(this).next('button').click();}">
                                 <button class="icon-search" tooltip-placement="right"
                                         tooltip="Search by application name.">
@@ -52,7 +52,7 @@
                     </tr>
                     </tfoot>
                     <tbody>
-                    <tr ng-repeat="app in applications">
+                    <tr ng-repeat="app in applications | filter:search">
                         <td><a href="#/realms/{{realm.id}}/applications/{{app.id}}">{{app.name}}</a></td>
                         <td>{{app.enabled}}</td>
                         <td ng-class="{'text-muted': !app.baseUrl}">{{app.baseUrl || "Not defined"}}</td>