From 78d75134f95dad937db29a1eb449cba02a5cabfe Mon Sep 17 00:00:00 2001
From: Eduard Gert <kontakt@eduardgert.de>
Date: Sat, 9 Mar 2024 17:14:41 +0100
Subject: [PATCH] Add better description for posture check activity events
 (#349)

---
 src/modules/activity/ActivityDescription.tsx | 259 ++++++++++++-------
 src/modules/activity/ActivityTypeIcon.tsx    |   5 +
 2 files changed, 172 insertions(+), 92 deletions(-)

diff --git a/src/modules/activity/ActivityDescription.tsx b/src/modules/activity/ActivityDescription.tsx
index 4baca2d..137ab98 100644
--- a/src/modules/activity/ActivityDescription.tsx
+++ b/src/modules/activity/ActivityDescription.tsx
@@ -31,6 +31,10 @@ export default function ActivityDescription({ event }: Props) {
 
   if (!m) return null;
 
+  /**
+   * Setup Key
+   */
+
   if (event.activity_code == "setupkey.revoke")
     return (
       <div className={"inline"}>
@@ -54,13 +58,6 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
-  if (event.activity_code == "dashboard.login")
-    return (
-      <div className={"inline"}>
-        <Value>{m.username}</Value> logged in to the dashboard
-      </div>
-    );
-
   if (event.activity_code == "setupkey.group.delete")
     return (
       <div className={"inline"}>
@@ -77,6 +74,20 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  /**
+   * Dashboard
+   */
+  if (event.activity_code == "dashboard.login")
+    return (
+      <div className={"inline"}>
+        <Value>{m.username}</Value> logged in to the dashboard
+      </div>
+    );
+
+  /**
+   * Policy
+   */
+
   if (event.activity_code == "policy.update")
     return (
       <div className={"inline"}>
@@ -98,6 +109,10 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  /**
+   * Route
+   */
+
   if (event.activity_code == "route.delete")
     return (
       <div className={"inline"}>
@@ -122,6 +137,10 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  /**
+   * User
+   */
+
   if (event.activity_code == "user.peer.delete")
     return (
       <div className={"inline"}>
@@ -150,6 +169,86 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  if (event.activity_code == "user.invite")
+    return (
+      <div className={"inline"}>
+        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>{" "}
+        was invited.
+      </div>
+    );
+
+  if (event.activity_code == "user.group.add")
+    return (
+      <div className={"inline"}>
+        Group <Value>{event.meta.group}</Value> was added to user{" "}
+        <Value>{event.meta.username}</Value>
+      </div>
+    );
+
+  if (event.activity_code == "user.block")
+    return (
+      <div className={"inline"}>
+        User <Value>{event.meta.username}</Value>{" "}
+        <Value>{event.meta.email}</Value>
+        was blocked
+      </div>
+    );
+
+  if (event.activity_code == "user.unblock")
+    return (
+      <div className={"inline"}>
+        User <Value>{event.meta.username}</Value>{" "}
+        <Value>{event.meta.email}</Value>
+        was unblocked
+      </div>
+    );
+
+  if (event.activity_code == "user.delete")
+    return (
+      <div className={"inline"}>
+        User <Value>{event.meta.username}</Value>{" "}
+        <Value>{event.meta.email}</Value> was deleted
+      </div>
+    );
+
+  if (event.activity_code == "user.group.delete")
+    return (
+      <div className={"inline"}>
+        Group <Value>{event.meta.group}</Value> was removed from user{" "}
+        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>
+      </div>
+    );
+
+  if (event.activity_code == "user.role.update")
+    return (
+      <div className={"inline"}>
+        Role <Value>{event.meta.role}</Value> was updated of user{" "}
+        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>
+      </div>
+    );
+
+  /**
+   * Service User
+   */
+
+  if (event.activity_code == "service.user.create")
+    return (
+      <div className={"inline"}>
+        Service user <Value>{event.meta.name}</Value> was created
+      </div>
+    );
+
+  if (event.activity_code == "service.user.delete")
+    return (
+      <div className={"inline"}>
+        Service user <Value>{event.meta.name}</Value> was deleted
+      </div>
+    );
+
+  /**
+   * Peer
+   */
+
   if (event.activity_code == "peer.group.delete")
     return (
       <div className={"inline"}>
@@ -216,6 +315,10 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  /**
+   * Group
+   */
+
   if (event.activity_code == "group.add")
     return (
       <div className={"inline"}>
@@ -223,6 +326,17 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  if (event.activity_code == "group.delete")
+    return (
+      <div className={"inline"}>
+        Group <Value>{event.meta.name}</Value> was deleted
+      </div>
+    );
+
+  /**
+   * Account
+   */
+
   if (event.activity_code == "account.create")
     return (
       <div className={"inline"}>
@@ -230,21 +344,18 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
-  if (event.activity_code == "user.invite")
-    return (
-      <div className={"inline"}>
-        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>{" "}
-        was invited.
-      </div>
-    );
+  if (event.activity_code == "account.setting.peer.login.expiration.update")
+    return <div className={"inline"}>Global login expiration was updated</div>;
 
-  if (event.activity_code == "user.group.add")
-    return (
-      <div className={"inline"}>
-        Group <Value>{event.meta.group}</Value> was added to user{" "}
-        <Value>{event.meta.username}</Value>
-      </div>
-    );
+  if (event.activity_code == "account.setting.peer.login.expiration.enable")
+    return <div className={"inline"}>Global login expiration was enabled</div>;
+
+  if (event.activity_code == "account.setting.peer.login.expiration.disable")
+    return <div className={"inline"}>Global login expiration was disabled</div>;
+
+  /**
+   * Nameserver
+   */
 
   if (event.activity_code == "nameserver.group.add")
     return (
@@ -267,14 +378,9 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
-  if (event.activity_code == "account.setting.peer.login.expiration.update")
-    return <div className={"inline"}>Global login expiration was updated</div>;
-
-  if (event.activity_code == "account.setting.peer.login.expiration.enable")
-    return <div className={"inline"}>Global login expiration was enabled</div>;
-
-  if (event.activity_code == "account.setting.peer.login.expiration.disable")
-    return <div className={"inline"}>Global login expiration was disabled</div>;
+  /**
+   * Personal Access Token
+   */
 
   if (event.activity_code == "personal.access.token.create")
     return (
@@ -292,68 +398,9 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
-  if (event.activity_code == "user.block")
-    return (
-      <div className={"inline"}>
-        User <Value>{event.meta.username}</Value>{" "}
-        <Value>{event.meta.email}</Value>
-        was blocked
-      </div>
-    );
-
-  if (event.activity_code == "user.unblock")
-    return (
-      <div className={"inline"}>
-        User <Value>{event.meta.username}</Value>{" "}
-        <Value>{event.meta.email}</Value>
-        was unblocked
-      </div>
-    );
-
-  if (event.activity_code == "user.delete")
-    return (
-      <div className={"inline"}>
-        User <Value>{event.meta.username}</Value>{" "}
-        <Value>{event.meta.email}</Value> was deleted
-      </div>
-    );
-
-  if (event.activity_code == "user.group.delete")
-    return (
-      <div className={"inline"}>
-        Group <Value>{event.meta.group}</Value> was removed from user{" "}
-        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>
-      </div>
-    );
-
-  if (event.activity_code == "user.role.update")
-    return (
-      <div className={"inline"}>
-        Role <Value>{event.meta.role}</Value> was updated of user{" "}
-        <Value>{event.meta.username}</Value> <Value>{event.meta.email}</Value>
-      </div>
-    );
-
-  if (event.activity_code == "service.user.create")
-    return (
-      <div className={"inline"}>
-        Service user <Value>{event.meta.name}</Value> was created
-      </div>
-    );
-
-  if (event.activity_code == "service.user.delete")
-    return (
-      <div className={"inline"}>
-        Service user <Value>{event.meta.name}</Value> was deleted
-      </div>
-    );
-
-  if (event.activity_code == "group.delete")
-    return (
-      <div className={"inline"}>
-        Group <Value>{event.meta.name}</Value> was deleted
-      </div>
-    );
+  /**
+   * Integration
+   */
 
   if (event.activity_code == "integration.create") {
     if (!event.meta.platform) return "Integration created";
@@ -385,7 +432,10 @@ export default function ActivityDescription({ event }: Props) {
     );
   }
 
-  // Group was added to DNS Management Setting that disables DNS for the group
+  /**
+   * DNS
+   */
+
   if (event.activity_code == "dns.setting.disabled.management.group.add")
     return (
       <div className={"inline"}>
@@ -402,6 +452,31 @@ export default function ActivityDescription({ event }: Props) {
       </div>
     );
 
+  /**
+   * Posture Checks
+   */
+
+  if (event.activity_code == "posture.check.updated")
+    return (
+      <div className={"inline"}>
+        Posture check <Value> {m.name}</Value> was updated
+      </div>
+    );
+
+  if (event.activity_code == "posture.check.created")
+    return (
+      <div className={"inline"}>
+        Posture check <Value> {m.name}</Value> was created
+      </div>
+    );
+
+  if (event.activity_code == "posture.check.deleted")
+    return (
+      <div className={"inline"}>
+        Posture check <Value> {m.name}</Value> was deleted
+      </div>
+    );
+
   // TODO add activity texts
   // rule.add
   // rule.update
diff --git a/src/modules/activity/ActivityTypeIcon.tsx b/src/modules/activity/ActivityTypeIcon.tsx
index 7b1e1ac..e42667d 100644
--- a/src/modules/activity/ActivityTypeIcon.tsx
+++ b/src/modules/activity/ActivityTypeIcon.tsx
@@ -12,6 +12,7 @@ import {
   NetworkIcon,
   Server,
   Shield,
+  ShieldCheck,
   User,
 } from "lucide-react";
 import React from "react";
@@ -70,6 +71,10 @@ export default function ActivityTypeIcon({
     return <User size={size} className={cn(DEFAULT_CLASSES, className)} />;
   } else if (code.startsWith("service")) {
     return <Cog size={size} className={cn(DEFAULT_CLASSES, className)} />;
+  } else if (code.startsWith("posture")) {
+    return (
+      <ShieldCheck size={size} className={cn(DEFAULT_CLASSES, className)} />
+    );
   } else {
     return (
       <HelpCircleIcon size={size} className={cn(DEFAULT_CLASSES, className)} />